Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use configNamespace for registering language providers of other extensions #95621

Merged
merged 1 commit into from May 11, 2020

Conversation

znck
Copy link
Contributor

@znck znck commented Apr 19, 2020

This PR fixes #75890

@msftclas
Copy link

msftclas commented Apr 19, 2020

CLA assistant check
All CLA requirements met.

@mjbvz
Copy link
Contributor

mjbvz commented Apr 20, 2020

Thanks for the PR.

Can you just provide a bit more detail on what you need #75890 for. It was opened almost a year ago and hasn't seen much attention since then

@znck
Copy link
Contributor Author

znck commented Apr 21, 2020

I am building a ts plugin for Vue. The config option either enables all the plugins or none. It was working till now because only one plugin (angular) existed. We need this if someone wants to enable Vue but disable angular.

The ts plugin for Vue would be used in vetur.

@mjbvz
Copy link
Contributor

mjbvz commented Apr 27, 2020

Thanks. It's pretty late in the VS Code iteration so I'm to take a look at this for May

@mjbvz mjbvz added this to the May 2020 milestone Apr 27, 2020
@mjbvz mjbvz merged commit 47c54f0 into microsoft:master May 11, 2020
@mjbvz
Copy link
Contributor

mjbvz commented May 11, 2020

Thanks!

@znck znck deleted the ts-plugin-config-namespace branch May 13, 2020 00:18
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript language server plugin should use a different workspace config key
3 participants