Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change all instances of wordHighligher to wordHighlighter #95830

Merged
merged 1 commit into from
Apr 27, 2020
Merged

change all instances of wordHighligher to wordHighlighter #95830

merged 1 commit into from
Apr 27, 2020

Conversation

dustypomerleau
Copy link
Contributor

@dustypomerleau dustypomerleau commented Apr 22, 2020

Thanks to all contributors for this awesome editor.

Merging this PR is optional, as the code in wordHighlighter.ts works as intended (the property with the typo is private, and the typo is perfectly reproduced each time it is used in the WordHighlighterContribution class). However, I think it future-proofs any potential code re-use down the road to correct all occurrences of the typo now.

@msftclas
Copy link

msftclas commented Apr 22, 2020

CLA assistant check
All CLA requirements met.

@alexdima
Copy link
Member

Thank you!

@alexdima alexdima added this to the April 2020 milestone Apr 27, 2020
@alexdima alexdima merged commit 73b5307 into microsoft:master Apr 27, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants