Avoid loading and twisty codicons set at the same time #95915
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for #95878 was that the loading codicon class name is set together with the twisty codicon class name.
That works as long as the CSS for the loading codicon is defined after the twisty CSS.
We want to avoid to depend on the CSS definition order. Instead, the PR nakes sure that only one icon class name is set at a time.
The fix changes the
ITreeRenderer.renderTwistie
API by adding aboolean
return type.renderTwistie
returnstrue
whenrenderTwistie
has rendered a twisty, orfalse
if not.The tree will only draw the regular twisty if
renderTwistie
has not already done so.Alternative would be to change the API to:
getTwistie?(element: T): Codicon | undefined;