Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve debug viewlet dropdown outline #95935

Merged
merged 2 commits into from Apr 24, 2020
Merged

Conversation

jeanp413
Copy link
Contributor

@jeanp413 jeanp413 commented Apr 23, 2020

This PR fixes #95870

debugviewletdropdownoutline

@isidorn isidorn self-assigned this Apr 23, 2020
@isidorn
Copy link
Contributor

isidorn commented Apr 23, 2020

Great PR as usual.
However there is one issue: you have increased the font size to 13. Even though I like that change, the issue is that all other dropdowns still use the font size 11. And we should be consistent and have the same font size.

So we have two options:

  • Reduce font size back to 11
  • Look into increasing all the other font sizes for our select boxes

fyi @misolori

@isidorn isidorn added the under-discussion Issue is under discussion for relevance, priority, approach label Apr 23, 2020
@jeanp413
Copy link
Contributor Author

jeanp413 commented Apr 23, 2020

@isidorn about the font size, when inspecting the select box element the rule font-size: 11px in start-debug-action-item wasn't being applied, instead the chrome default (13.333px) was being used so I just change it to 13px to keep de layout as before. I can revert that change back to 11px.

P.S. I checked the other select boxes like the one in terminal and output panel and they don't have the 11px rule applied to them either so maybe that's a bug?

@isidorn
Copy link
Contributor

isidorn commented Apr 23, 2020

@jeanp413 I think I know what the issue is. I am on Mac and you are on some other platform.
On the mac we use the native select boxes, on other platform we have our own select box solution.
And when I try it on the mac I see the font size difference, and you probably do not see it since it might not be aplied to our custom select box.

Yes, I suggest to just revert the font size change.

@jeanp413
Copy link
Contributor Author

Reverted the font size back to 11px.

@jeanp413 I think I know what the issue is. I am on Mac and you are on some other platform.
On the mac we use the native select boxes, on other platform we have our own select box solution.

I'm on linux ubuntu 18.04 and the native <select> element is used
The below screenshot is from stable where you can see the font size used is 13.333px

image

@isidorn
Copy link
Contributor

isidorn commented Apr 24, 2020

Ok, this is great now.
Might be then that this font is only applied on the mac, thus I see the difference and you do not.

All in all, great PR. Merging in. Thanks a lot!

@isidorn isidorn merged commit e06e812 into microsoft:master Apr 24, 2020
@isidorn isidorn added this to the April 2020 milestone Apr 24, 2020
@jeanp413 jeanp413 deleted the fix-95870 branch April 24, 2020 13:55
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent focus feedback on dropdown
2 participants