Move EnvironmentVariableCollection API into ExtensionContext #96061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@connor4312 you can make your extension update change on this branch, I still need to fix up the tests before merging is all. |
|
Bumping js-debug requires updating distro as well. To avoid getting out of lockstep, let me know when you're ready to merge this and then I'll merge and bump at the same time. |
|
@connor4312 good to go, provided CI passes. |
|
Manually queued a build as it was stuck https://dev.azure.com/vscode/VSCode/_build/results?buildId=41874&view=results |
|
Ok, cool. I'm out for a bit as mentioned, I'll bump, verify, and merge after standup. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #46696