Fixes #95162: preLaunchTask should complete before resolveDebugConfig…

[gustavomassa]

This PR fixes #95162

• The preLaunchTask was being executed on the final execution of createSession function, calling the runTaskAndCheckErrors function passing the preLaunchTask string name as taskId parameter.

• When preLaunchTask is undefined/null, the taskId is also undefined/null, resolving a null promise, consequently resulting in a successful task.

• The substituteVariables function is responsible for calling the execution of command:PickProcess, therefore the preLaunchTask should exec before.

[msftclas]

All CLA requirements met.

[daniv-msft]

Hi @alexr00 ,

Could you please provide an estimation on how long it usually takes to approve this kind of PRs and integrate them in VS Code?
This bug is blocking us as well, as our scenario relies on injecting environment variables in the debug session, and for that we need the preLaunchTask to run before resolveDebugConfiguration.

Thanks,
Dan

[alexr00]

@daniv-msft this PR fell off my radar, and it looks like it would be better reviewed by one of the folk who works on debug. I've re-assigned to the appropriate person.

[daniv-msft]

Thank you for your reply @alexr00!

[isidorn]

Thank you for the PR and sorry for the slow response I was on vacation.
I have commented here #95162 (comment)
Due to that pushing this to On-Deck. If you have thoughts please comment on the issue, thanks!

[isidorn]

As discussed in #95162
We will do a different approach. Due to that closing this PR.
Thanks anyways!