Use generic for providers with resolve methods #96955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #95852 Some of our providers have two phases: provide and resolve. This change updates the typings to make it clearer that the values returned by provider are passed into resolve.
mjbvz
commented
May 5, 2020
src/vs/vscode.d.ts
Outdated
| * @param token A cancellation token. | ||
| * @return The given, resolved code lens or thenable that resolves to such. | ||
| */ | ||
| resolveCodeLens?(codeLens: CodeLens, token: CancellationToken): ProviderResult<CodeLens>; | ||
| resolveCodeLens?(codeLens: T, token: CancellationToken): ProviderResult<CodeLens>; |
There was a problem hiding this comment.
I've kept ProviderResult<CodeLens> here because we don't require that resolve returns the same type of code lens it was given. Let me know if you think we should just make it ProviderResult<T> as well
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95852
Some of our providers have two phases: provide and resolve. This change updates the typings to make it clearer that the values returned by provider are passed into resolve.