Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the debug.enableAllHovers settings #97153

Closed
andrecasal opened this issue May 7, 2020 · 2 comments
Closed

Remove the debug.enableAllHovers settings #97153

andrecasal opened this issue May 7, 2020 · 2 comments
Assignees
@isidorn
Labels
debt Code quality issues
Milestone
May 2020

Comments

@andrecasal
Copy link

  • VSCode Version: Insiders 1.45.0
  • OS Version: macOS 10.15.4

Steps to Reproduce:

  1. Open your default settings
  2. Notice the debug.enableAllHovers setting still exists but it is not used

The debug.enableAllHovers setting was added as a workaround for the LiveShare extension which no longer uses it and also seems to have no plans to use it in the future. I suggest we remove this setting from VS Code entirely.

Does this issue occur when all extensions are disabled? Yes
@andrecasal andrecasal changed the title Remove debug.enableAllHovers Remove the debug.enableAllHovers settings May 7, 2020
@isidorn isidorn added the debt Code quality issues label May 7, 2020
@isidorn isidorn closed this as completed in 1934836 May 7, 2020
@isidorn isidorn added this to the May 2020 milestone May 7, 2020
@isidorn
Copy link
Contributor

isidorn commented May 7, 2020

@andrecasal awesome, thanks for pushing this. I just removed it.

@andrecasal
Copy link
Author

You're very welcome, thanks 👍

@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
debt Code quality issues
Projects
None yet
Milestone
May 2020
Development

No branches or pull requests
2 participants
@isidorn @andrecasal