Rename github-authentication to github #97889
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaomoreno
commented
May 15, 2020
| @@ -80,7 +80,7 @@ export class GitHubServer { | |||
| this.updateStatusBarItem(true); | |||
|
|
|||
| const state = uuid(); | |||
| const callbackUri = await vscode.env.asExternalUri(vscode.Uri.parse(`${vscode.env.uriScheme}://vscode.github-authentication/did-authenticate`)); | |||
| const callbackUri = await vscode.env.asExternalUri(vscode.Uri.parse(`${vscode.env.uriScheme}://vscode.github/did-authenticate`)); | |||
There was a problem hiding this comment.
@RMacfarlane Do we need to update the callback URLs also in the app registrations?
There was a problem hiding this comment.
Yep, that's right! GitHub actually has control over this so I will reach out on getting this updated
|
@RMacfarlane From what I understand, there seems to be no problem renaming the extension, as far as the auth API goes since it doesn't actually know which extension calls |
|
Decided to take another approach: I'll create a |
|
Sounds good! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the plan item:
From microsoft/vscode-pull-request-github#1788
After the rename, we can start adding features in the extension.
@RMacfarlane Need your eyes on this since renaming the extension from with an auth provider comes might have unforeseen consequences. What do you think?