Move webview's use of setIgnoreMenuShortcuts to main process

[mjbvz]

Part of #95955

Switches from calling setIgnoreMenuShortcuts in our renderers processes to instead call it in the main process

[bpasero]

Is this helpful? Should it not use the log service instead?

[bpasero]

Instead of using raw IPC I would prefer to go through IElectronService and friends if possible. We need to move off the direct IPC usage.

[mjbvz]

Thanks for the suggestion. Just pushed an update that moves to use channels instead. I've never worked with these directly before so let me know I've I'm using them incorrectly

[bpasero]

@mjbvz thanks, any reason you decided to introduce a new service vs. just using the existing IElectronService?

I typically prefer to call interfaces XY-Main-XY only when they are only used in electron-main. In your case I would rename it to IWebviewService. But again, I think everything can reuse the existing electron service for this purpose.

[mjbvz]

@bpasero Webviews require a number of ipc calls:

• setIgnoreMenuShortcuts (this PR)
• Local resource protocol loading (currently also using ipc instead of a service)
• Port forwarding (not implemented yet)

I felt it would be better to have these all in a webview specific service rather than adding them to IElectronService. I can put them in IElectronService if you feel this would be better

[bpasero]

@mjbvz ok I wasn't aware there are more methods needed. I think it is fine to have your own service then as long as you set it up the way the electron service is setup, e.g. using the createChannelReceiver/createChannelSender helpers.

[mjbvz]

@bpasero Thanks. I've aligned the service more with ElectronMainService. I'm going to merge this PR and then move the existing webview protocol handling code from using ipc to use this service instead

[bpasero]

I suggest you look at createChannelReceiver/createChannelSender, with that you do not need to explicitly implement any methods, the helper will do everything for you. Check how IElectronService works, there is no duplication to spell out the methods or events, it is all handled automatically via Proxy.

[mjbvz]

Ah ok, I'll update it to use createChannelReceiver too to cut down on the duplicated code