Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook: weird find widget animation #99371

Closed
joaomoreno opened this issue Jun 4, 2020 · 3 comments
Closed

Notebook: weird find widget animation #99371

joaomoreno opened this issue Jun 4, 2020 · 3 comments
Assignees
@rebornix
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook ux User experience issues verified Verification succeeded
Milestone
June 2020

Comments

@joaomoreno
Copy link
Member

recording (17)

It feels like it's hiding behind something, but it's not!
@rebornix
Copy link
Member

rebornix commented Jun 5, 2020

It's weird compared to the find widget for monaco, which will be always inside the editor area but this one is on top of the editor toolbar for a bit of time.

@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug notebook ux User experience issues labels Jun 5, 2020
@rebornix rebornix added this to the June 2020 milestone Jun 5, 2020
@joaomoreno
Copy link
Member Author

So let's not have it go up and down, but rather fade in/out?

@rebornix
Copy link
Member

With some CSS tricks, the find widget behaves the same as the one in text editor.

This was referenced Jul 2, 2020
Closed
Closed
@joaomoreno joaomoreno added the verified Verification succeeded label Jul 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook ux User experience issues verified Verification succeeded
Projects
None yet
Milestone
June 2020
Development

No branches or pull requests
3 participants
@joaomoreno @rebornix and others