ActionBar: only navigate on one key #99959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or next since not all users can see orientation" This reverts commit 9d68bd2.
|
I am not sure if I can review this, maybe Steven should? |
isidorn
requested review from
bpasero and
sbatten
and removed request for
bpasero
|
Makes sense. I think there is no hurry so let's wait for @sbatten to wake up and review :) |
sbatten
approved these changes
Jun 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99907
I have changed the action bar such that it navigates next with both
rigthtanddownkey and to navigate previous with bothupandleft. Idea being that not all users can see the orientation.Unfortunetly this breaks the custom menu which rellyes on the left / right navigation keys not being used to jump to other menus.
The fix is a simple revert and is low risk - we are just going to previous behavior.
I have verified this indeed fixes the issue.