Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some XmlReaders in XmlRunSettingsUtilities are not disposed #5093

Closed
omajid opened this issue Jun 11, 2024 · 0 comments · Fixed by #5094
Closed

Some XmlReaders in XmlRunSettingsUtilities are not disposed #5093

omajid opened this issue Jun 11, 2024 · 0 comments · Fixed by #5094

Comments

@omajid
Copy link
Contributor

omajid commented Jun 11, 2024

Description

In XmlRunSettingsUtilities, we allocate various XmlReaders but don't always Diposes them

Steps to reproduce

var reader = XmlReader.Create(stringReader, ReaderSettings);

This is never Dispose()d.

Expected behavior

All IDisposables are disposed.

Actual behavior

Some IDisposables are not disposed in XmlRunSettingsUtilities.

Diagnostic logs

N/A

Environment

Commit 9ab8d6c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant