Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CodeBase for existing inproc collector settings #2331

Merged
merged 11 commits into from May 31, 2021

Conversation

MarcoRossignoli
Copy link
Contributor

@MarcoRossignoli MarcoRossignoli commented Feb 15, 2020

In-proc coverlet collector is injected by collect arg processor.
If no coverlet in-proc setting is found full xml element properties setting is injected.
If coverlet in-proc setting is found we ensure to setup mandatory field AssemblyQualifiedName CodeBase IsEnabled
Past fix to avoid custom code to pass adapters path to host fixed "default" and most common case where no in-proc element is present #2288

This PR fix the case where in-proc element is present and codebase is null.
Check for codebase if null search using adapter path if null setup default coverlet codebase CoverletConstants.CoverletDataCollectorCodebase

BTW after #2288 in-proc collector won't be injected because coverlet nuget adapter path won't be passed to testhost.

In conclusion...to work coverlet needs adapter path loaded in TestAdaptersPaths.

cc: @nohwnd @jakubch1 @vagisha-nidhi

@ghost
Copy link

ghost commented May 31, 2021

Hello @Haplois!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@Haplois Haplois merged commit 5b1d7b8 into microsoft:main May 31, 2021
@MarcoRossignoli MarcoRossignoli deleted the inprocload branch February 1, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants