Don't parallelize default platform tests #3849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MarcoRossignoli the static platform check strikes again. Probably no time to do it the better way we discussed in this sprint. (By adding a "userSet" field on each node in runsettings. |
Evangelink
approved these changes
Jul 13, 2022
| @@ -2578,9 +2579,14 @@ private void DiscoverTestsIfThrowsExceptionShouldThrowOut(Exception exception) | |||
| [DataRow("x86")] | |||
| [DataRow("x64")] | |||
| [DataRow("arm64")] | |||
| // Don't parallelize because we can run into conflict with GetDefaultArchitecture -> RunSettingsHelper.Instance.IsDefaultTargetArchitecture | |||
There was a problem hiding this comment.
Could we rework the static so that the test can be run in parallel?
There was a problem hiding this comment.
Yes, if we do the work to populate the attribute on the actual runsettings text and read it from there.
test/vstest.console.UnitTests/TestPlatformHelpers/TestRequestManagerTests.cs
Outdated
Show resolved
Hide resolved
Yeah...it's on backlog. |
MarcoRossignoli
approved these changes
Jul 13, 2022
…anagerTests.cs Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
Evangelink
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not parallelize tests for default platform.