Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vote count contrast issue #39

Closed
polatengin opened this issue Jul 8, 2020 · 1 comment · Fixed by #83
Closed

vote count contrast issue #39

polatengin opened this issue Jul 8, 2020 · 1 comment · Fixed by #83
Labels
enhancement New feature or request STATE-pendingDesignReview

Comments

@polatengin
Copy link
Collaborator

I noticed the vote count on the retro board is very faded and hard to see. This is especially the case when it’s being shared in a meeting. For example, I couldn’t tell if the number is 6 or 8 during the meeting when someone else’s sharing their screen.

contrast issue

Would you consider using a different color with higher contrast for better accessibility?

Original issue reported by Mandy Chan from Microsoft
@polatengin polatengin added the enhancement New feature or request label Jul 8, 2020
@polatengin polatengin added this to Backlog in v1.5 via automation Jul 8, 2020
@JankaKoen
Copy link

Hi Engin! There are clear rules for accessibility and color contrast. I will make a suggestion to address and improve this. J.

@yayitserica yayitserica removed this from Backlog in v1.5 Jul 17, 2020
@polatengin polatengin mentioned this issue Dec 5, 2020
Merged
polatengin pushed a commit that referenced this issue May 13, 2022
@NarmathaBala @focusthenflex
@argoldbe @mhassaninmsft @msa2984 @phongcao @mindlessroman @nexilus18
Nabalas/newdev (#70)
071c378 
* Add jest-cli tool

* Add jest testing to devDependencies

* Add ts testing capability & example test

* [1418] Create dev backend IaC scripts and doc  (#6)

* Updates to Backend to support developer backend deployment
* Updates to Frontend to remove prod specific config
* Integrate build and deploy .NET project into setup script
* Add backend deployment instructions

Co-authored-by: Ari Goldberg <argoldbe@microsoft.com>
Co-authored-by: Mohamed Hassanin <mhassanin@microsoft.com>

* Task 1407: Prevent duplicate downvotes or upvotes (#2)

Prevent duplicate downvotes or upvotes by disabling the vote button for an item while the current user's vote for it is being processed.

* Merging changes from the upstream into dev branch (#9)

Merging changes from upstream repo into dev branch

* Task 1421: Prevent Deletion of Feedback Items with upvotes (#3)

* Disable delete button when feedback items have upvotes; edit title for
button to provide context.

* [1377] Migrating to new Azure DevOps Extension SDK (#4)

* Replacing 'vss-web-extension-sdk' with 'azure-devops-extension-api' and 'azure-devops-extension-sdk':
- Most data contracts stay the same so we just need to change the importing paths.
- Changing the way we invoke services (required by the new sdk) and adding servicesHelper file containing helper methods.
- Re-writing logic where async calls are required instead of synchronous ones.
- Most REST client classes have been changed in the new sdk.

* Task 1401: Adding a Frontend Entity Relationship Diagram (#1)

Includes an entity relationship diagram that maps out the relationship of the different components in the tool. Helpful for visualizing how the components interconnect.

Co-authored-by: Hannah Kennedy <hakenned@microsoft.com>

* [1423] Integrate localhost development process (#7)

This PR helps improve the development loop. It allows developers to test changes without having to re-publish the extension in the marketplace

Add changes needed for the Hot Reload & Debug process
Update documentation

* [1485] Set up basic ci workflows for backend/frontend components (#12)

* Refactored ci workflows to support validating both backend/frontend components.

* Fixed ci issue. (#18)

* Improve Jest Configuration (#17)

update Jest configuration to add Junit reporter and handle Azure DevOps npm packages and Office Fabric UI npm packages.

* Small readme update

* Updating readme file.

* Fixing PR status checks (#24)

* Fixing PR status checks.
* Updated path filtering for backend/frontend ci trigger conditions.

* Add Application insights to React App (#14)

* Add Application insight to react component

* Fixed ci issues. (#25)

* Adding App Insights resource creation to infrastructure scripts (#13)

* Creating AppInsights as IAC

* Adding Application Insights Appsettings

* add settings

* Updating existing appsetting with  properties

* Reflecting instrumentation key updates

* Reverting dev changes

* Updating packag-lock.json

Co-authored-by: Narmatha <Narmatha.Balasundaram@microsoft.com>

* Add AzCLI and zip to dockerfile (#15)

* Add AzCLI and zip packages to the dev Container via dockerfile

* [1495] Fixing warnings and add more linter rules to help with code formatting (#16)

* Added linter rules to help with code format.
* Fixed linter errors and warnings issues.

* #1497 Add test visualization for frontend (#26)

Test visualization for frontend.

* Fixed bug #1522 and #1532. (#34)

* [1494, 1498] Adding unit tests for backend component and replacing GitHub Autobuild (#30)

* Added unit tests for backend component. Replaced GitHub autobuild and code analysis by manual build steps.
* Add test visualization for backend
* Update .gitignore to include TestResults folder

Co-authored-by: Neyissa Exilus <nexilus@microsoft.com>

* Adding tokenHelper which replaces jsonwebtoken package and reduces bundle size (#31)

* Added tokenHelper to replace jsonwebtoken npm package.

* User Story #1413: Obscure Feedback of Others During Collection (#33)

* Primarily: adjusting conditional for the blurring other's feedbacks when boards are anonymous. 
* Secondarily: Adjusting white space. Updating the Readme: (readability, accessibility, new information)

Co-authored-by: Hannah Kennedy <hakenned@microsoft.com>

* Log client side information to Application Insights (#29)

Add Application Insights logging to Front end and React Error boundaries.

* Improve backend application insights and logging reporting (#32)

- Improve backend application insights and logging reporting (#32)
Co-authored-by: Phong Cao <thcao@microsoft.com>

* [Task 1470] Part 1: Add Basic Rendering Test + Mocks (#38)

* [Tasks 1540, 1541] Add Snapshots and basic rendering tests (#40)

Co-authored-by: Phong Cao <thcao@microsoft.com>
Co-authored-by: Andrew Francisque <andrew.francisque@gmail.com>

* Mhassanin/feature dashboadrs cli (#46)

Deploy Dashboards for Application Insights as IaC.
Co-authored-by: Ari Goldberg

* [1505] Add ci script and integration with dev container, local dev env, pipeline & pre-commit hook.  (#39)

- Add ci.sh and setup_ci.sh scripts to be used in dev container, local dev env and in pipelines
- Updates to dev container config to support ci scripts
- Add pre-commit integration & config
- Add detect-secrets integration

Co-authored-by: Ari Goldberg <argoldbe@microsoft.com>

* Update node to v16. (#49)

* [Task 1469] Add basic rendering tests for boardSummary component (#48)

* Update package-lock.json to sync with new node version. (#56)

* [Task 1471] Feedback Board Container Tests (#55)

- Also added tests for editableDocumentCardTitle, feedbackCarousel, and workflowStage.

* [1496] Adding CD workflow for frontend (#53)

* Added CD workflow for frontend.

* Improve webpack configuration handling (#57)

Improve Config Handling for the frontend React App

* User Story 1415: Grouped Items in Focus Mode (#59)

* Items grouped under another can be made visible in focus mode on desktop view.

Co-authored-by: Hannah Kennedy <hakenned@microsoft.com>

* [Task 1569]: Contributing Updates (#60)

* [1503] Deploy Alerts as IAC (#58)

This PR includes implementation of the alerts as IAC.

An action group for email notification and the following alerts are being deployed:

Failed requests
Server Exceptions
Response Time
Browser Exceptions

* Issue #305: Change the formatting for the timer to be 00:00 (#62)

* Change the formatting for the timer to be 00:00

Co-authored-by: Hannah Kennedy <hakenned@microsoft.com>
Co-authored-by: Marisa <38594207+msa2984@users.noreply.github.com>

* Issues 308, 318: Grouping Within or Across Columns, New Modal Design (#64)

Now a setting when creating a retrospective exists, that when enabled, grouping across columns is allowed, and when disabled, grouping can only occur within a column.

Additionally, some visual changes to the create/edit retro modal.

Co-authored-by: Hannah Kennedy <hakenned@microsoft.com>

* Add Code Coverage Badge (#63)

*Code Coverage PR

* fix build failure on merge (#65)

* fix build failure on merge

* disable PR comments (#66)

* disable PR comments

* fix merge problem with pr comments (#67)

* Removing jest.config.js

* Remove a file and update a .gitignore entry.

Co-authored-by: Andrew Francisque <andrew.francisque@gmail.com>
Co-authored-by: Andrew Francisque <anfranc@microsoft.com>
Co-authored-by: Ari Goldberg <36014594+argoldbe@users.noreply.github.com>
Co-authored-by: Ari Goldberg <argoldbe@microsoft.com>
Co-authored-by: Mohamed Hassanin <mhassanin@microsoft.com>
Co-authored-by: Marisa <38594207+msa2984@users.noreply.github.com>
Co-authored-by: Phong Cao <phong.caothai@live.com>
Co-authored-by: Hannah K <hannah.kennedy@microsoft.com>
Co-authored-by: Hannah Kennedy <hakenned@microsoft.com>
Co-authored-by: Neyissa Exilus <68079902+nexilus18@users.noreply.github.com>
Co-authored-by: mhassaninmsft <97306532+mhassaninmsft@users.noreply.github.com>
Co-authored-by: Narmatha <Narmatha.Balasundaram@microsoft.com>
Co-authored-by: Neyissa Exilus <nexilus@microsoft.com>
Co-authored-by: Phong Cao <thcao@microsoft.com>
Co-authored-by: Hannah K <mindless.roman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request STATE-pendingDesignReview
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixing styles and focus mode dialog polatengin/vsts-extension-retrospectives
3 participants
@polatengin @yayitserica @JankaKoen