Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api-extractor] Invalid types being generated when using barred o and export aliases #1471

Closed
1 of 2 tasks
alan-agius4 opened this issue Aug 19, 2019 · 3 comments · Fixed by #1493
Closed
1 of 2 tasks
Labels
bug Something isn't working as intended effort: easy Probably a quick fix. Want to contribute? :-)

Comments

@alan-agius4
Copy link
Contributor

alan-agius4 commented Aug 19, 2019

Is this a feature or a bug?

  • Feature
  • Bug

Please describe the actual behavior.
When having an exported class with a name prefixed with a barred o ɵ and is also exported using an alias invalid rolled up typings are being generated.

Input

export declare class ɵNgNoValidate {}
export {ɵNgNoValidate as NgNoValidate__0}

Output

declare class "ɵNgNoValidate" { }
export { "ɵNgNoValidate" as NgNoValidate__0 }
export { "ɵNgNoValidate" as ɵNgNoValidate }
export { }

What is the expected behavior?
Correct output.

declare class ɵNgNoValidate { }
export { ɵNgNoValidate as NgNoValidate__0 }
export { ɵNgNoValidate }
export { }

If this is a bug, please provide the tool version, Node.js version, and OS.

  • Tool: @microsoft/api-extractor
  • Tool Version: 7.3.8
  • Node Version: 12.6.0
    • Is this a LTS version?
    • Have you tested on a LTS version? No
  • OS: Mojave
@alan-agius4
Copy link
Contributor Author

//cc @octogonz, this used to work in 7.0

@octogonz octogonz added bug Something isn't working as intended effort: easy Probably a quick fix. Want to contribute? :-) help wanted If you're looking to contribute, this issue is a good place to start! labels Aug 27, 2019
@octogonz octogonz removed the help wanted If you're looking to contribute, this issue is a good place to start! label Aug 29, 2019
@octogonz
Copy link
Collaborator

@alan-agius4 Here's a PR: #1471

@alan-agius4
Copy link
Contributor Author

Thanks @pgonzal for this.

Ps: I think you meant #1493 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended effort: easy Probably a quick fix. Want to contribute? :-)
Projects
None yet
2 participants