ExpandEnvAndSearchPath not /permissive- clean

[zx64]

Tested against 4361351

Test file (in root of repo for simplicity)

#define WIN32_LEAN_AND_MEAN
#include <windows.h>
#include <cstdint> // for SIZE_MAX in resource.h
#include "include/wil/win32_helpers.h"
int main() {}

> cl testwil.cpp /W4 /WX /permissive-
Microsoft (R) C/C++ Optimizing Compiler Version 19.20.27508.1 for x64
Copyright (C) Microsoft Corporation.  All rights reserved.

testwil.cpp
[...]/include/wil/win32_helpers.h(190): error C2760: syntax error: unexpected token 'identifier', expected ';'
[...]/include/wil/win32_helpers.h(190): error C7510: 'unique_cotaskmem_string': use of dependent type name must be prefixed with 'typename'

That appears to be the only blocker to making that header compile with /permissive-.

[dunhor]

Looks like win32_helpers.h under-includes its dependencies. Objbase.h should be included before resource.h. In the meantime, this can be worked around by either including this file before win32_helpers.h or by not defining WIN32_LEAN_AND_MEAN

[jonwis]

The environment string code appears to use unique_cotaskmemstring_ptr as its default output type. Is there a good reason to use that vs wil::unique_process_heap_string_ptr or a wistd::unique_ptr<wchar_t> instance? Changing the default in the OS repo might hit compilation errors as a result of code like:

wil::unique_cotaskmemstring_ptr evar = ExpandEnvironmentStringsW(L"%muffin%");

[jonwis]

Should be fixed now.