2020 is a leapyear

[mgradwohl]

2020 is a leap year and there are lot of times developers do things like manipulate SYSTEMTIME or FILETIME or convert from one to another, and they do not take into account leap years. C# has AddYears() for this.

WIL should implement safe date manipulation methods like C# so that 2020 isn't a mess.

[sylveon]

There already is SystemTimeToFileTime and the reverse for conversion between the two.

…

On Tue, Aug 20, 2019, 12:52 Matt Gradwohl ***@***.***> wrote: 2020 is a leap year and there are lot of times developers do things like manipulate SYSTEMTIME or FILETIME or convert from one to another, and they do not take into account leap years. C# has AddYears() <https://docs.microsoft.com/en-us/dotnet/api/system.datetime.addyears?view=netframework-4.8> for this. WIL should implement safe date manipulation methods like C# so that 2020 isn't a mess. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#86?email_source=notifications&email_token=ABRELNU4GBE4S7XSI5ZPMLTQFQOMLA5CNFSM4INZ6QEKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HGJSYDA>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABRELNWW34HGSSYNXLWQBGLQFQOMLANCNFSM4INZ6QEA> .

[mgradwohl]

SystemTimeToFileTime and the reverse for conversion actually causes problems, this is exactly why .net has AddYears().

[jonwis]

@ShawnSteele - are there Windows platform APIs to manipulating times like the .NET versions?

This - standard APIs for manipulating times - might be a good fit for http://github.com/microsoft/projectreunion

[sylveon]

And 2 years later we have C++20's std::chrono dates which correctly handles leap years and leap seconds. I'm not sure date manipulation APIs are a good fit for Project Reunion, this topic should be best left to the language implementation/standard library.

[jonwis]

I'm going to close this for now since we support std::chrono everywhere it needs to be.

WinAppSDK might still be a reasonable place to put language-agnostic date manipulation methods based on the WinRT DateTime & TimeSpan structs, but most language runtimes have a preferred version they already provide.