Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating packaging docs for runFullTrust capability and multiple applications #24

Merged
merged 5 commits into from
May 26, 2023

Conversation

lilybarkley-msft
Copy link
Contributor

Clarifying that AppSilos can't be mixed and matched with other app types, and clarified runFullTrust capability

@@ -72,6 +74,9 @@ on the size of the package.
* In `<Application>` replace any existing entrypoint/trustlevel/runtimebehavior with
`uap10:TrustLevel="appContainer" previewsecurity2:RuntimeBehavior="appSilo"`

* In `<Capabilities>` it is safe to remove the `<rescap:Capability name="runFullTrust">` unless
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does comServer require runFullTrust to support running the Com Server isolated? That seems like a bug to me. Ideally the guidance should be to remove runFullTrust.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple extensions do, ComServer, FirewallRules, comInterface. I've forwarded the team an email with some context from the COM team

docs/packaging/msix-packaging-tool.md Outdated Show resolved Hide resolved
@@ -72,6 +74,11 @@ on the size of the package.
* In `<Application>` replace any existing entrypoint/trustlevel/runtimebehavior with
`uap10:TrustLevel="appContainer" previewsecurity2:RuntimeBehavior="appSilo"`

* **Note**: By default MPT, will automatically add `<rescap:Capability name="runFullTrust">` to
`<Capabilities>` due to the app being a packaged Win32. This should be removed unless unless
the app has other manifested extensions which can affect the global machine state, such as
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
the app has other manifested extensions which can affect the global machine state, such as
the app has other manifested extensions which can affect the user global state, such as

@lilybarkley-msft lilybarkley-msft merged commit c32f3cd into microsoft:main May 26, 2023
2 checks passed
@lilybarkley-msft lilybarkley-msft deleted the Capability-Update branch May 26, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants