Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: D3D12_COMMAND_QUEUE_DESC::Priority is i32 instead of D3D12_COMMAND_QUEUE_PRIORITY #1579

Closed
sydcgbw opened this issue May 16, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@sydcgbw
Copy link

sydcgbw commented May 16, 2023

Which crate is this about?

windows

Crate version

0.48.0

Summary

The type of windows::Win32::Graphics::Direct3D12::D3D12_COMMAND_QUEUE_DESC::Priority should be windows::Win32::Graphics::Direct3D12::D3D12_COMMAND_QUEUE_PRIORITY instead of i32.

Toolchain version/configuration

Default host: x86_64-pc-windows-msvc
rustup home: C:\Users\sydcgbw.rustup

stable-x86_64-pc-windows-msvc (default)
rustc 1.69.0 (84c898d65 2023-04-16)

Reproducible example

use windows::Win32::Graphics::Direct3D12::*;

fn main()
{
    let CommandQueueDesc = D3D12_COMMAND_QUEUE_DESC
    {
        Type: D3D12_COMMAND_LIST_TYPE_NONE,
        Priority: D3D12_COMMAND_QUEUE_PRIORITY_NORMAL,
        Flags: D3D12_COMMAND_QUEUE_FLAG_NONE,
        NodeMask: 0
    };
}

Crate manifest

# ...

[dependencies.windows]
version = "0.48.0"
features = [
    "Win32_Graphics_Direct3D12"
]

Expected behavior

No error

Actual behavior

mismatched types
expected i32, found D3D12_COMMAND_QUEUE_PRIORITY

Additional comments

No response

@sydcgbw sydcgbw added the bug Something isn't working label May 16, 2023
@kennykerr
Copy link
Contributor

Seems related to #1573 - I can transfer to the metadata repo for consideration.

@kennykerr kennykerr transferred this issue from microsoft/windows-rs May 16, 2023
@kennykerr
Copy link
Contributor

Didn't @damyanp say that these are relative values?

@mikebattista
Copy link
Contributor

No this is a different API. If it behaves the same way though let me know.

@damyanp
Copy link
Member

damyanp commented May 16, 2023

It behaves the same way, i32 is correct.

mikebattista added a commit that referenced this issue May 16, 2023
…12_COMMAND_QUEUE_PRIORITY. Fixed #1579."

This reverts commit b32e111.
@mikebattista
Copy link
Contributor

Reverted. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants