Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateLogFile_fCreateDispositionFlags should be removed in favor of FILE_CREATE_FLAGS #365

Closed
AArnott opened this issue Mar 16, 2021 · 0 comments
Labels
usability Touch-up to improve the user experience for a language projection

Comments

@AArnott
Copy link
Member

AArnott commented Mar 16, 2021

This is causing a CsWin32 test to be unstable. Today, both of these enums exist. Can we remove the second one?

public enum FILE_CREATE_FLAGS : uint
{
	CREATE_NEW = 1u,
	CREATE_ALWAYS,
	OPEN_EXISTING,
	OPEN_ALWAYS,
	TRUNCATE_EXISTING
}

public enum CreateLogFile_fCreateDispositionFlags : uint
{
	CREATE_NEW = 1u,
	OPEN_EXISTING = 3u,
	OPEN_ALWAYS = 4u,
	CREATE_ALWAYS = 2u,
	TRUNCATE_EXISTING = 5u
}
@AArnott AArnott added the usability Touch-up to improve the user experience for a language projection label Mar 16, 2021
AArnott added a commit to microsoft/CsWin32 that referenced this issue Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability Touch-up to improve the user experience for a language projection
Projects
None yet
Development

No branches or pull requests

1 participant