Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate PROCESSOR_ARCHITECTURE values #1530

Merged
merged 3 commits into from Apr 10, 2023

Conversation

riverar
Copy link
Collaborator

@riverar riverar commented Apr 10, 2023

Fixes: #1529

@mikebattista Heads up, this moves several values from Windows.Win32.System.SystemServices to Windows.Win32.System.Diagnostics.Debug. Is that what we want? (These values are in winnt.h and are not debug specific.)

@mikebattista
Copy link
Contributor

I would probably change the order of the uses so the enum moves to System.SystemInformation next to SYSTEM_INFO.

@riverar
Copy link
Collaborator Author

riverar commented Apr 10, 2023

@mikebattista Agreed. Will change.

@riverar riverar force-pushed the rafael/processor_architecture branch from 08306d9 to b806b6d Compare April 10, 2023 17:34
@mikebattista mikebattista merged commit 669f781 into microsoft:main Apr 10, 2023
1 check passed
@riverar riverar deleted the rafael/processor_architecture branch April 10, 2023 19:10
mikebattista added a commit that referenced this pull request Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing constant for arm64 architecture
2 participants