tools/api: Speed up fmt from 1min to 18s by writing to rustfmt stdin #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using forward slashes makes it so that all the tools generate files into the proper directories on Linux - otherwise new folders/files with `\\` in the name are created, and none of the existing files are properly overwritten.
This reintroduces the "pipe Rust code through rustfmt before writing to disk" code from [microsoft#828] and yields a massive performance improvement for running in parallel over all files now, and not having to write, read, and write the same files over again. Unfortunately Rust's `Command` structure does not yet have proper support for forwarding stdout to a file (that's not unix-specific), though it could possibly be beneficial to write chunks read from stdout directly to a file instead of reading the whole lot into memory first. [microsoft#828]: microsoft#828
kennykerr
reviewed
Oct 28, 2021
MarijnS95
force-pushed
the
rustfmt-parallel
branch
2 times, most recently
from
52aee5e
to
3ecd976
Compare
kennykerr
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reintroduces the "pipe Rust code through rustfmt before writing to disk" code from #828 and yields a massive performance improvement for running in parallel over all files now, and not having to write, read, and write the same files over again.
Unfortunately Rust's
Commandstructure does not yet have proper support for forwarding stdout to a file (that's not unix-specific), though it could possibly be beneficial to write chunks read from stdout directly to a file instead of reading the whole lot into memory first.