Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpler const representation for GUIDs #1306

Merged
merged 2 commits into from Nov 11, 2021
Merged

Simpler const representation for GUIDs #1306

merged 2 commits into from Nov 11, 2021

Conversation

kennykerr
Copy link
Collaborator

@kennykerr kennykerr commented Nov 10, 2021

As suggested in #1292. Turns out this particular change wasn't affecting compile time. Thanks @saschanaz!

@kennykerr kennykerr merged commit 1801b69 into master Nov 11, 2021
@kennykerr kennykerr deleted the from_u128 branch November 11, 2021 00:13
@saschanaz
Copy link

Curious, what was affecting the build time then? 👀

@kennykerr
Copy link
Collaborator Author

I was comparing path = "/git/windows-rs" (my local clone) with version = "0.26" and for some reason it is always a few seconds slower using the former. Not sure why. So I compared a few different clones using different branches and confirmed this particular change didn't actually regress compile time and actually produces a smaller package.

@kennykerr kennykerr mentioned this pull request Nov 15, 2021
@GamePad64 GamePad64 mentioned this pull request May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants