Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where COM interfaces needed to be declared pub #1611

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Fix bug where COM interfaces needed to be declared pub #1611

merged 1 commit into from
Mar 17, 2022

Conversation

rylev
Copy link
Contributor

@rylev rylev commented Mar 17, 2022

Fixes another issue found in #1486 where it was always necessary to mark an interface as pub.

@rylev rylev requested a review from kennykerr March 17, 2022 17:20
kennykerr
kennykerr approved these changes Mar 17, 2022
View reviewed changes
Copy link
Collaborator

@kennykerr kennykerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kennykerr kennykerr merged commit d88dab4 into microsoft:master Mar 17, 2022
@kennykerr kennykerr mentioned this pull request Mar 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennykerr kennykerr kennykerr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rylev @kennykerr