Stateful metadata & bindgen #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riverar
reviewed
May 24, 2022
Comment on lines
+13
to
+16
| // TODO: workaround for https://github.com/microsoft/win32metadata/issues/814 | ||
| if type_name.name == "INetCfgComponentUpperEdge" { | ||
| return quote! {}; | ||
| } |
There was a problem hiding this comment.
I believe this can be removed now. Was fixed in a release in March.
There was a problem hiding this comment.
They claim to have removed it but it's back. Anyway, I excluded it here to make diffing simpler, but I can now remove this exclusion.
riverar
reviewed
May 24, 2022
| } | ||
|
|
||
| impl TypeAttributes { | ||
| pub fn union(&self) -> bool { |
There was a problem hiding this comment.
Nit: This is really ExplicitLayout right, which could or could not be related to unions.
There was a problem hiding this comment.
Yep, I can use the more explicit 😉 name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing metadata reader is the last holdover from the old
buildmacro and the switch to pre-generated bindings. It provided a static type reader that could be shared by multiple invocations of the various code generation macros but was rather difficult to use in a more traditional procedural model since you couldn't give it an explicit set of winmd files or control the lifetime of the metadata reader. Unfortunately, the static nature of the metadata had a rather viral effect on dependencies which took me quite a lot of work to untangle.The new metadata reader can now be created and dropped as needed and given an explicit set of winmd files to parse. This also ends up being a lot faster. The port still has a few rough edges, but I'd like to get this in and deal with the stragglers in upcoming PRs as this change has been in the pipeline for long enough. Feel free to comment and I'll address feedback in subsequent PRs.
Fixes #1406