Remove nightly test distinction #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Simplifying the yml generation seems to now exceed VM capacity. Perhaps it allows cargo to cache more stuff. |
rylev
suggested changes
May 25, 2022
There was a problem hiding this comment.
Seems like the CI takes much longer to run now. It's a shame that for some reason so much build artifact is being created that we run out of disk space. However, I think calling cargo clean before every test is probably over kill. It should be relatively straight forward to only add cargo clean once half way through.
|
I suspect it takes longer because it now runs all tests on both nightly and stable whereas before it only ran half on stable and half on nightly. |
rylev
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1771