Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid redundant signature calculations #1793

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Avoid redundant signature calculations #1793

merged 1 commit into from
Jun 2, 2022

Conversation

kennykerr
Copy link
Collaborator

Another technical debt around calculating method signature dependencies. This also fixes a few bugs in cfg generation where generic dependencies were skipped.

rylev
rylev approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this ok though I'm not really familiar with the cfg resolution code. I did have one question though...

crates/libs/windows/src/Windows/Web/Http/Headers/mod.rs Show resolved Hide resolved
@kennykerr kennykerr merged commit 0421721 into master Jun 2, 2022
@kennykerr kennykerr deleted the signature-cfg branch June 2, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rylev rylev rylev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kennykerr @rylev