Remove flatten comment
#1801
Merged
Remove flatten comment
#1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AronParker
approved these changes
Jun 6, 2022
There was a problem hiding this comment.
Seems reasonable. At best performance is improved from 62 to 6 microseconds, which is probably lost in noise as to my understanding the flatten call is only done once and not in a tight loop. Also by merging the recursive or iterative approaches I outlined here a lot of readability/simpliticty/maintainability gets lost. So I'm all for it.
rylev
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1795 and analysis by @AronParker and @rylev,
flattencannot be turned into a pure iterator as Rust doesn't appear to support recursive iterators. rust-lang/rust#97686Here I'm just removing the comment as there's no more work to be done here.