Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test error propagation #1803

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Test error propagation #1803

merged 1 commit into from
Jun 7, 2022

Conversation

kennykerr
Copy link
Collaborator

As I work on splitting the core modules out as separate crates, I noticed we don't have a specific test to ensure error propagation does not regress.

@riverar
Copy link
Collaborator

riverar commented Jun 7, 2022

Another thing I noticed is when we call message(), the call to GetErrorDetails/GetDescription/etc. may result in a message that includes a pesky line break.

This results in undesirable side effects when printing these messages, e.g.:

Error: Error { code: 0x8007007E, message: The specified module could not be found.
 }

Separate PR is in order to detect/strip these.

@kennykerr
Copy link
Collaborator Author

@riverar Yep, that's something that I trimmed automatically in cppwinrt - I'll do the same for Rust.

@kennykerr kennykerr mentioned this pull request Jun 7, 2022
@kennykerr kennykerr merged commit acba9c2 into master Jun 7, 2022
@kennykerr kennykerr deleted the test_error_propagation branch June 7, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants