Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add display methods for string pointer types #1904

Merged
merged 3 commits into from Jul 13, 2022

Conversation

rylev
Copy link
Contributor

@rylev rylev commented Jul 13, 2022

Since string pointer types cannot safely implement Display, we use the same pattern as Path from the std library which has a display method on it which returns an impl Display. This allows users to display these string types without needing to allocate a temporary string.

@kennykerr kennykerr merged commit 8c093b4 into microsoft:master Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants