Fix groups inside namespaces in build!
#806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `BuildMacro::parse` tracks the current namespace-path with a
single mutable string throughout the walking of the `UseTree`. When the
walking of a `UseTree::Path` is completed, it incorrectly forgets to pop
that sub-namespace off the namespace-path string. As a result, when a
`UseTree::Group` contains more than one sub-`UseTree`s, latter
sub-`UseTree`s are walked with a namespace-path that has the leaf
sub-namespaces of the previous sub-`UseTree`s incorrectly infixed into
it:
```rust
// builds A.B.C and A.B.D.E, should build A.B.C and A.D.E
windows::build!(
A::{B::C, D::E}
);
```
This commit fixes that by cloning the namespace-path string when walking
a `UseTree::Group`.
It also changes the diagnostics when trying to importing a nonexistent
item in the global namespace from `.Foo` to `(global namespace).Foo`.
kennykerr
requested changes
May 17, 2021
kennykerr
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
BuildMacro::parsetracks the current namespace-path with asingle mutable string throughout the walking of the
UseTree. When thewalking of a
UseTree::Pathis completed, it incorrectly forgets to popthat sub-namespace off the namespace-path string. As a result, when a
UseTree::Groupcontains more than one sub-UseTrees, lattersub-
UseTrees are walked with a namespace-path that has the leafsub-namespaces of the previous sub-
UseTrees incorrectly infixed intoit:
This commit fixes that by cloning the namespace-path string when walking
a
UseTree::Group.It also changes the diagnostics when trying to importing a nonexistent
item in the global namespace from
.Footo(global namespace).Foo.