Skip to content

Commit

Permalink
Make v2 index EF enabled by default (#4553)
Browse files Browse the repository at this point in the history
## Change
Enable the v2 index experimental feature by default as it seems to be
functioning properly and this will increase coverage.
  • Loading branch information
JohnMcPMS committed Jun 14, 2024
1 parent 8503a86 commit 2e01798
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 16 deletions.
7 changes: 0 additions & 7 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -243,13 +243,6 @@ jobs:
isPackaged: true
filter: "TestCategory!=InProcess&TestCategory!=OutOfProcess"

- template: templates/e2e-test.template.yml
parameters:
title: "E2E Tests Packaged (Index V2)"
isPackaged: true
filter: "TestCategory!=InProcess&TestCategory!=OutOfProcess"
experimentalFeatures: indexV2

- template: templates/e2e-test.template.yml
parameters:
title: "Microsoft.Management.Deployment E2E Tests (In-process)"
Expand Down
8 changes: 0 additions & 8 deletions src/AppInstallerCLIE2ETests/FeaturesCommand.cs
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,6 @@ public void DisplayFeatures()
var result = TestCommon.RunAICLICommand("features", string.Empty);
Assert.AreEqual(Constants.ErrorCode.S_OK, result.ExitCode);
Assert.True(result.StdOut.Contains("Direct MSI Installation"));
if (WinGetSettingsHelper.ForcedExperimentalFeatures.Length > 0 && WinGetSettingsHelper.ForcedExperimentalFeatures[0] != "none")
{
Assert.True(result.StdOut.Contains("Enabled"));
}
else
{
Assert.False(result.StdOut.Contains("Enabled"));
}
}

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion src/AppInstallerCommonCore/Public/winget/UserSettings.h
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ namespace AppInstaller::Settings
SETTINGMAPPING_SPECIALIZATION(Setting::EFSideBySide, bool, bool, false, ".experimentalFeatures.sideBySide"sv);
SETTINGMAPPING_SPECIALIZATION(Setting::EFConfigureSelfElevation, bool, bool, false, ".experimentalFeatures.configureSelfElevate"sv);
SETTINGMAPPING_SPECIALIZATION(Setting::EFStoreDownload, bool, bool, false, ".experimentalFeatures.storeDownload"sv);
SETTINGMAPPING_SPECIALIZATION(Setting::EFIndexV2, bool, bool, false, ".experimentalFeatures.indexV2"sv);
SETTINGMAPPING_SPECIALIZATION(Setting::EFIndexV2, bool, bool, true, ".experimentalFeatures.indexV2"sv);
SETTINGMAPPING_SPECIALIZATION(Setting::EFConfigureExport, bool, bool, false, ".experimentalFeatures.configureExport"sv);
// Telemetry
SETTINGMAPPING_SPECIALIZATION(Setting::TelemetryDisable, bool, bool, false, ".telemetry.disable"sv);
Expand Down

0 comments on commit 2e01798

Please sign in to comment.