Cherry pick: Fix xamlAsset value (powershell module) (#4240) and Fix …

…PowerShellCmdlet (#4247) (#4248)
microsoft · Mar 7, 2024 · ce2f0c0 · ce2f0c0
1 parent 91d6e81
commit ce2f0c0
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 9 deletions.
diff --git a/src/PowerShell/CommonFiles/PowerShellCmdlet.cs b/src/PowerShell/CommonFiles/PowerShellCmdlet.cs
@@ -1,4 +1,4 @@
-// -----------------------------------------------------------------------------
+// -----------------------------------------------------------------------------
 // <copyright file="PowerShellCmdlet.cs" company="Microsoft Corporation">
 //     Copyright (c) Microsoft Corporation. Licensed under the MIT License.
 // </copyright>
@@ -281,6 +281,7 @@ internal void Wait(Task runningTask, PowerShellCmdlet? writeCmdlet = null)
                     {
                         try
                         {
+                            this.pwshThreadEdi = null;
                             this.pwshThreadAction();
                         }
                         catch (Exception e)
@@ -596,12 +597,17 @@ private void WaitMainThreadActionCompletion()
                 this.pwshThreadActionCompleted.WaitHandle,
             });
 
-            if (this.pwshThreadEdi != null)
+            try
             {
-                this.pwshThreadEdi.Throw();
+                if (this.pwshThreadEdi != null)
+                {
+                    this.pwshThreadEdi.Throw();
+                }
+            }
+            finally
+            {
+                this.semaphore.Release();
             }
-
-            this.semaphore.Release();
         }
 
         private class QueuedStream

diff --git a/src/PowerShell/Microsoft.WinGet.Client.Engine/Helpers/AppxModuleHelper.cs b/src/PowerShell/Microsoft.WinGet.Client.Engine/Helpers/AppxModuleHelper.cs
@@ -379,10 +379,10 @@ private async Task InstallVCLibsDependenciesAsync()
         private async Task InstallUiXamlAsync(string releaseTag)
         {
             (string xamlPackageName, string xamlReleaseTag) = GetXamlDependencyVersionInfo(releaseTag);
-            string xamlAssetX64 = string.Format($"{0}.x64.appx", xamlPackageName);
-            string xamlAssetX86 = string.Format($"{0}.x86.appx", xamlPackageName);
-            string xamlAssetArm = string.Format($"{0}.arm.appx", xamlPackageName);
-            string xamlAssetArm64 = string.Format($"{0}.arm64.appx", xamlPackageName);
+            string xamlAssetX64 = string.Format("{0}.x64.appx", xamlPackageName);
+            string xamlAssetX86 = string.Format("{0}.x86.appx", xamlPackageName);
+            string xamlAssetArm = string.Format("{0}.arm.appx", xamlPackageName);
+            string xamlAssetArm64 = string.Format("{0}.arm64.appx", xamlPackageName);
 
             var uiXamlObjs = this.GetAppxObject(xamlPackageName);
             if (uiXamlObjs is null)