Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages that do not upgrade o report incorrect package version #1192

Closed
musm opened this issue Jun 21, 2021 · 7 comments
Closed

Packages that do not upgrade o report incorrect package version #1192

musm opened this issue Jun 21, 2021 · 7 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Author-Feedback Issue needs attention from issue or PR author No-Recent-Activity Issue has no recent activity
Milestone

Comments

@musm
Copy link

musm commented Jun 21, 2021

The following packages

Cisco Webex Meetings              Cisco.CiscoWebexMeetings 41.5.4       41.5.6.9    winget
Geekbench 5                       PrimateLabs.Geekbench.5  Unknown      5.4.1       winget
Mozilla Firefox                   Mozilla.Firefox          89.0         89.0.1      winget
WhatsApp                          WhatsApp.WhatsApp        2.2121.6     2.2123.7    winget
Microsoft Windows Desktop Runtime Microsoft.dotnetRuntime  3.1.16.30112 5.0.7.30113 winget

Prepetually state that they are upgradable, despite upgrading them multiple times. I suspect there is an issue somewhere with the packages reporitng their version numbers.

@OfficialEsco
Copy link

TLDR; This is a winget CLI issue, the package versions are correct

PS C:\Users\Esco> winget install Cisco.CiscoWebexMeetings; winget install PrimateLabs.Geekbench.5; winget install Mozilla.Firefox ; winget install WhatsApp.WhatsApp ; winget install Microsoft.dotnetRuntime
Found Cisco Webex Meetings [Cisco.CiscoWebexMeetings]
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://akamaicdn.webex.com/client/WBXclient-41.5.6-9/webexapp.msi
  ██████████████████████████████   130 MB /  130 MB
Successfully verified installer hash
Starting package install...
Successfully installed
Found Geekbench 5 [PrimateLabs.Geekbench.5]
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://cdn.geekbench.com/Geekbench-5.4.1-WindowsSetup.exe
  ██████████████████████████████   119 MB /  119 MB
Successfully verified installer hash
Starting package install...
Successfully installed
Found Mozilla Firefox [Mozilla.Firefox]
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://download-installer.cdn.mozilla.net/pub/firefox/releases/89.0.1/win64/en-US/Firefox%20Setup%2089.0.1.msi
  ██████████████████████████████  53.3 MB / 53.3 MB
Successfully verified installer hash
Starting package install...
Successfully installed
Found WhatsApp [WhatsApp.WhatsApp]
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://web.whatsapp.com/desktop/windows/release/x64/WhatsAppSetup.exe
  ██████████████████████████████   124 MB /  124 MB
Successfully verified installer hash
Starting package install...
Successfully installed
Found Microsoft Windows Desktop Runtime [Microsoft.dotnetRuntime]
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://download.visualstudio.microsoft.com/download/pr/2b83d30e-5c86-4d37-a1a6-582e22ac07b2/c7b1b7e21761bbfb7b9951f5b258806e/windowsdesktop-runtime-5.0.7-win-x64.exe
  ██████████████████████████████  52.3 MB / 52.3 MB
Successfully verified installer hash
Starting package install...
Successfully installed
PS C:\Users\Esco> winget list
Name                                       Id                                         Version          Available Source
-----------------------------------------------------------------------------------------------------------------------
Geekbench 5                                PrimateLabs.Geekbench.5                    Unknown          5.4.1     winget
Mozilla Firefox                            Mozilla.Firefox                            89.0.1
WhatsApp                                   WhatsApp.WhatsApp                          2.2123.7
Microsoft Windows Desktop Runtime          Microsoft.dotnetRuntime                    5.0.7.30113
Cisco Webex Meetings                       Cisco.CiscoWebexMeetings                   41.5.6.9

Geekbench is not reporting its version so that is a Geekbench issue.

PS C:\Users\Esco> winget upgrade
Name        Id                      Version Available Source
------------------------------------------------------------
Geekbench 5 PrimateLabs.Geekbench.5 Unknown 5.4.1     winget

image

@denelon denelon transferred this issue from microsoft/winget-pkgs Jun 21, 2021
@ghost ghost added the Needs-Triage Issue need to be triaged label Jun 21, 2021
@denelon denelon added Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Triage Issue need to be triaged labels Jun 21, 2021
@KaranKad
Copy link

Might be related to this #1191 (comment)

@musm
Copy link
Author

musm commented Jun 21, 2021

@KaranKad That does indeed seem to fix the Mozilla and WhatsApp issues. Hopefully when those packages get an update, I won't have the same problem.

@musm
Copy link
Author

musm commented Jun 29, 2021

So geekbench doesn't report the correct version, it seems like it would make sense for winget-cli to then fallback gracefuly to the verison recorded in the Manifest? That should be doable if winget records the installed version for packages through winget-pkgs.

@denelon
Copy link
Contributor

denelon commented Feb 18, 2022

We've started recording the packages installed by Windows Package Manager. The challenge is we're not informed when a user performs an upgrade outside of the package manager, and if they don't report the version information in Windows Apps & Features. We have no way of knowing which version is currently installed. We could still inadvertently downgrade a user.

@denelon denelon modified the milestones: v1.3-Client, v1.4-Client May 31, 2022
@denelon
Copy link
Contributor

denelon commented Jun 21, 2022

I think we've captured the scenarios here in Windows Package Manager 1.3 Release Candidate.

The exclusion of "Unknown" packages by default in winget upgrade --all gets some of them and I believe the rest are captured by:

Can you confirm?

@denelon denelon added the Needs-Author-Feedback Issue needs attention from issue or PR author label Jun 21, 2022
@ghost ghost added the No-Recent-Activity Issue has no recent activity label Jun 28, 2022
@ghost
Copy link

ghost commented Jun 28, 2022

@musm this issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@denelon denelon closed this as completed Aug 8, 2022
Client-Bugs automation moved this from To Do to Done Aug 8, 2022
Client-Current automation moved this from To do to Done Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Author-Feedback Issue needs attention from issue or PR author No-Recent-Activity Issue has no recent activity
Projects
Development

No branches or pull requests

4 participants