Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repair an App that is behaving badly #148

Closed
Tracked by #989
denelon opened this issue May 15, 2020 · 2 comments
Closed
Tracked by #989

Repair an App that is behaving badly #148

denelon opened this issue May 15, 2020 · 2 comments
Labels
Issue-Feature This is a feature request for the Windows Package Manager client.
Milestone
v1.7 Client

Comments

@denelon
Copy link
Contributor

denelon commented May 15, 2020 •
edited

As a user I want to be able to repair my app if it is not working correctly.

Client:
winget repair <appname>

Repair can only be done as a single apps as it doesn't seem to make sense to do this for all installed applications.

Most installers have a repair mode.

  1. add repair command to YAML spec. this is probably the systemappid
  2. search the ARP for the command and be able to call it.
  3. this should also work for MSIX which are uwp store apps.
@denelon denelon added the Issue-Feature This is a feature request for the Windows Package Manager client. label May 15, 2020
@Atemu
Copy link

Atemu commented May 19, 2020

The easiest way to repair something is usually to uninstall the package and install the same version again.
An explicit repair operation might not be necessary.

@denelon denelon added this to the Package Manager Backlog milestone May 23, 2020
@denelon denelon changed the title --repair Repair an App that is behaving badly May 23, 2020
@aycippo
Copy link

aycippo commented May 15, 2023

@denelon if it is not too much of an addition though, perhaps the addition of an --all or --tags options to the repair command? I think that would be useful to have in the of chances you are looking to repair your environment or a specific set of tools.

I would also think that since this would vary wildly between each package we would need to make sure that winget can understand and make the correct changes based on how it was installed. might be useful to consider a sort of package maintainer side doc/script/template that winget could follow in which they add this information.

@joadoumie joadoumie mentioned this issue May 31, 2023
Open
@denelon denelon modified the milestones: Backlog-Client, v1.7 Client Jul 21, 2023
@denelon denelon mentioned this issue Jul 27, 2023
Open
@denelon denelon modified the milestones: v1.7 Client, 1.8 Client Aug 15, 2023
@denelon denelon mentioned this issue Aug 21, 2023
Open
@denelon denelon modified the milestones: 1.8 Client, v1.7 Client Oct 12, 2023
@denelon denelon mentioned this issue Dec 1, 2023
Open
2 tasks
@Madhusudhan-MSFT Madhusudhan-MSFT mentioned this issue Jan 8, 2024
Merged
3 tasks
Madhusudhan-MSFT added a commit that referenced this issue Jan 17, 2024
@Madhusudhan-MSFT
Repair switch support for V1.7 YAML manifest (#4041)
4993e4b 
Add YAML manifest entries for winget repair behavior

Manifest Entries includes:
- The `Repair `switch, within `InstallerSwitch,` allows for custom
repair of a package.
- The `RepairBehavior` enum field, present in the Installer & root level
field, determines the repair behavior for the source package used to
repair a package.
- Updated the test manifest (ManifestV1_7-MultiFile-Installer.yaml) and
the test code that validate the Repair switch and RepairBehavior fields.

**[How Validated:]**
- Made the necessary changes to the manifest
- Ran the ManifestValidation tests that are part of AppInstallerCLITests
and verified that all the tests passed

**[Test Result:]**
```
Filters: [ManifestValidation]
===============================================================================
All tests passed (4008 assertions in 30 test cases)

Filters: [ManifestCreation]
===============================================================================
All tests passed (1309 assertions in 7 test cases)
```
**TODO's:**

- [ ] Determine the interdependency validation between the
"RepairBehavior" and "Repair" fields. Should this be a semantic
validation or a validation at the time of workflow execution as an early
validation step?



<!-- To check a checkbox place an "x" between the brackets. e.g: [x] -->

- [x] I have signed the [Contributor License
Agreement](https://cla.opensource.microsoft.com/microsoft/winget-pkgs).
- [x] This pull request is related to an issue.

Related to : 

*  #148 

-----

###### Microsoft Reviewers: [Open in
CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/4041)
@denelon denelon closed this as completed Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
Windows Package Manager Current
Status: Done
Milestone
v1.7 Client
Development

No branches or pull requests
3 participants
@Atemu @aycippo @denelon