Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax Regex Validation on Protocols #1994

Closed
Trenly opened this issue Mar 2, 2022 · 1 comment
Closed

Relax Regex Validation on Protocols #1994

Trenly opened this issue Mar 2, 2022 · 1 comment
Labels
Area-Manifest This may require a change to the manifest Issue-Feature This is a feature request for the Windows Package Manager client.
Milestone
v1.4-Client

Comments

@Trenly
Copy link
Contributor

Trenly commented Mar 2, 2022

Description of the new feature / enhancement

The current schema does not allow for protocols to start with a number

winget-cli/schemas/JSON/manifests/v1.2.0/manifest.installer.1.2.0.json

Lines 208 to 218 in 739aefe

"Protocols": {
"type": [ "array", "null" ],
"items": {
"type": "string",
"pattern": "^[a-z][-a-z0-9\\.\\+]*$",
"maxLength": 2048
},
"maxItems": 16,
"uniqueItems": true,
"description": "List of protocols the package provides a handler for"
},

This causes issues when Publishers implement their own protocols or handlers such as 360chromexurl

Proposed technical implementation details

The regex should be relaxed to allow for custom protocols and handlers which start with numbers or removed entirely
@Trenly Trenly added the Issue-Feature This is a feature request for the Windows Package Manager client. label Mar 2, 2022
@ghost ghost added the Needs-Triage Issue need to be triaged label Mar 2, 2022
@denelon denelon mentioned this issue Mar 2, 2022
Closed
@denelon denelon added Area-Manifest This may require a change to the manifest and removed Needs-Triage Issue need to be triaged labels Mar 2, 2022
@ryfu-msft ryfu-msft mentioned this issue Mar 3, 2022
Closed
@ryfu-msft ryfu-msft mentioned this issue Mar 17, 2022
Merged
@Trenly
Copy link
Contributor Author

Trenly commented Aug 3, 2022 •
edited
Loading

Resolved in #2028

@Trenly Trenly closed this as completed Aug 3, 2022
@denelon denelon added this to the v1.4-Client milestone Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Manifest This may require a change to the manifest Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
None yet
Milestone
v1.4-Client
Development

No branches or pull requests
2 participants
@Trenly @denelon