Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for 1.2 Schema Additions #2028

Merged
merged 19 commits into from
Apr 1, 2022

Conversation

ryfu-msft
Copy link
Contributor

@ryfu-msft ryfu-msft commented Mar 17, 2022

This PR updates the 1.2 schema to incorporate the proposed changes from #1891. This only adds functionality for parsing and processing the new schema additions and does not include their respective feature support.

Also includes additional proposed arguments and settings schema changes for installing portables. Excludes some of the installer manifest changes for the portable feature as those will be included with the work for the portable install feature which will have more thorough testing.

Related to:

Microsoft Reviewers: Open in CodeFlow

@ryfu-msft ryfu-msft requested a review from a team as a code owner March 17, 2022 18:38
@ryfu-msft ryfu-msft requested a review from yao-msft March 17, 2022 18:39
@ryfu-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@Trenly Trenly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not leaving some of these comments regarding number of nodes and the enum in the original PR (#1996)

@ghost ghost added the Needs-Author-Feedback Issue needs attention from issue or PR author label Mar 23, 2022
@ghost ghost removed the Needs-Author-Feedback Issue needs attention from issue or PR author label Mar 28, 2022
@ghost ghost removed the Needs-Author-Feedback Issue needs attention from issue or PR author label Mar 30, 2022
Copy link
Contributor

@Trenly Trenly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the documentations a bit more, it seems that with the proposed schema, the Documentations (if not null) could be an empty array, or an array of empty objects.

I also think that we should force quality here, and require that each Documentation require the URL and Description, as a documentation without a URL is meaningless and a URL without a description may be confusing

@Trenly

This comment was marked as resolved.

@ryfu-msft
Copy link
Contributor Author

Looking at the documentations a bit more, it seems that with the proposed schema, the Documentations (if not null) could be an empty array, or an array of empty objects.

I also think that we should force quality here, and require that each Documentation require the URL and Description, as a documentation without a URL is meaningless and a URL without a description may be confusing

I discussed with the team and I decided to not follow through with these changes. There are a lot of components such as WingetCreate, WingetSvc, and other 3rd parties that rely on the schema and adding more constraints could be breaking. These changes will require more thorough testing that I won't address in this PR, so I will stick with the existing pattern.

Copy link
Contributor

@yao-msft yao-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ghost ghost added the Needs-Author-Feedback Issue needs attention from issue or PR author label Apr 1, 2022
@ghost ghost removed the Needs-Author-Feedback Issue needs attention from issue or PR author label Apr 1, 2022
@ryfu-msft ryfu-msft merged commit 6e9e10e into microsoft:master Apr 1, 2022
@ryfu-msft ryfu-msft deleted the 1_2schemaSupport branch April 1, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants