Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: winget pin add --id is broken with sideBySide experimental feature #4354

Closed
mdanish-kh opened this issue Apr 5, 2024 · 5 comments
Labels
Command-Pin Issue related to WinGet Pin Experimental This experimental feature can be enabled in settings Issue-Bug It either shouldn't be doing this or needs an investigation.
Milestone

Comments

@mdanish-kh
Copy link
Contributor

mdanish-kh commented Apr 5, 2024

Brief description of your issue

winget pin add with the --id filter does not work in the v1.8.924-preview build. Without the --id parameter the command works as expected

Steps to reproduce

~ winget -v
v1.7.10861
 ~ winget pin add --id Discord.Discord
Found Discord [Discord.Discord]
Pin added successfully
 ~ winget pin remove --id Discord.Discord
Found Discord [Discord.Discord]
Pin removed successfully

[update winget to preview build]

Important

Enable side by side experimental feature

[pin without --id works]

 ~ winget pin add Discord.Discord
Found Discord [Discord.Discord]
Pin added successfully

[pin with --id does not work]

 ~ winget -v
v1.8.924-preview
 ~ winget pin add --id Discord.Discord
Found Discord [Discord.Discord]
An unexpected error occurred while executing the command:
GetVariant(14)
0x80070490 : Element not found.

Expected behavior

Pin added successfully

Actual behavior

 ~ winget pin add --id Discord.Discord
Found Discord [Discord.Discord]
An unexpected error occurred while executing the command:
GetVariant(14)
0x80070490 : Element not found.

Logs

WinGet-2024-04-05-21-21-51.529.log

Environment

~ winget --info
Windows Package Manager (Preview) v1.8.924-preview
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22631.3296
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.23.924.0

Winget Directories
-------------------------------------------------------------------------------------------------------------------------------
Logs                               %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir
User Settings                      %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\settings.json
Portable Links Directory (User)    %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User)       %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root              C:\Program Files\WinGet\Packages
Portable Package Root (x86)        C:\Program Files (x86)\WinGet\Packages
Installer Downloads                %USERPROFILE%\Downloads

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Admin Setting                             State
--------------------------------------------------
LocalManifestFiles                        Enabled
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride                     Enabled
LocalArchiveMalwareScanOverride           Disabled
ProxyCommandLineOptions                   Disabled
DefaultProxy                              Disabled
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage Issue need to be triaged label Apr 5, 2024
Copy link

github-actions bot commented Apr 5, 2024

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Open similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@microsoft-github-policy-service microsoft-github-policy-service bot added Command-Pin Issue related to WinGet Pin Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Triage Issue need to be triaged labels Apr 5, 2024
@denelon denelon added this to the 1.8 Client milestone Apr 5, 2024
@mdanish-kh
Copy link
Contributor Author

mdanish-kh commented Apr 6, 2024

Testing this further...this only occurs when I enable the sideBySide experimental feature. Setting the experimental flag to false resolves the issue

@mdanish-kh mdanish-kh changed the title Regression: winget pin add --id is broken on 1.8 preview build Regression: winget pin add --id is broken with sideBySide experimental feature Apr 6, 2024
@mdanish-kh
Copy link
Contributor Author

[Policy] Experimental

@JohnMcPMS
Copy link
Member

Circling back on this, I cannot reproduce now after #4432

@mdanish-kh
Copy link
Contributor Author

Just tried it on preview release v1.9.1551-preview that shipped with the changes in PR #4432. The issue's resolved at my end as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Command-Pin Issue related to WinGet Pin Experimental This experimental feature can be enabled in settings Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

No branches or pull requests

3 participants