Add Workflow logs and fix installed version workflow bug #4432
Conversation
| break; | ||
| } | ||
|
|
||
| UNREFERENCED_PARAMETER(map); |
There was a problem hiding this comment.
Do we plan to use this variable in the future?
There was a problem hiding this comment.
I had considered a much more complex runtime checking with tasks actually having information on which data they produced/consumed, but realized that a runtime check is only as good as the tests and so provided very little value. I didn't feel like removing the parameter at that point.
| @@ -1365,6 +1365,8 @@ namespace AppInstaller::Repository | |||
| } | |||
| } | |||
|
|
|||
| using namespace anon; | |||
There was a problem hiding this comment.
curious why do we need to change the empty namespace?
There was a problem hiding this comment.
I've learned that anonymous namespace does not output type information into the PDB in a way that debuggers can find currently, making it much harder to debug. With a named namespace, the derived type information is found and so the debugger can show the member fields of a derived type (vtable -> type mapping). One can manually do all of this with enough effort, and maybe eventually the debuggers will support it directly, but at this time I see simply naming the namespace as the easiest answer.
Fixes #4425
Change
This adds a
Workflowchannel (disabled by default) that has the entry to tasks and theGet/Add/Containscalls logged to it. This enables a view into a flow that can be collected by a third party.It also fixes a behavior change with the side-by-side code path for selecting the installed version that would lead to no data item being inserted, when the previous behavior was that a
nullptrwould be inserted when no version is installed.Validation
Manual validation of the workflow output, including using the windbg command to see the function name (for function pointer tasks).
Manual validation of at least one case of the
GetVariant(14)issue being fixed.Microsoft Reviewers: Open in CodeFlow