Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure available packages match with a single installed package #1473

Merged
merged 4 commits into from Sep 24, 2021

Conversation

florelis
Copy link
Member

@florelis florelis commented Sep 16, 2021

When searching for installed packages matching an available package, if there were multiple matches we would create multiple results for the search. This caused commands that require a single match, like import or upgrade, to fail. Modified to select a single installed package as match if it has a strong match (product code or package family name).

This partially fixes #983 in that import and upgrade now won't fail for packages like Teams, but does not address the underlying issue of how we should deal with packages that have multiple ARP entries.


Also, modified dependencies code to check the experimental feature only once.

Microsoft Reviewers: Open in CodeFlow

@florelis florelis requested a review from a team as a code owner September 16, 2021 21:18
@ghost ghost added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Sep 16, 2021
@florelis florelis merged commit 6813f33 into microsoft:master Sep 24, 2021
@florelis florelis deleted the InstalledMultiMatch branch September 24, 2021 00:16
@DrCaos
Copy link

DrCaos commented Feb 17, 2022

we have that problem when we want uninstall teams ;(
image

@denelon
Copy link
Contributor

denelon commented Feb 17, 2022

@lechacon, does this also address the issue with uninstall also?

@florelis
Copy link
Member Author

I think it should. The change was at the source search level, so it would affect anything that calls into it, including uninstall. I just tried it and uninstall worked for me.

@DrCaos , what version of winget are you using? (Output of winget --info)

@gulshan
Copy link

gulshan commented Mar 19, 2022

Also facing the multiple teams issue. winget cannot upgrade teams-
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
5 participants