Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit tests in pipeline #1529

Merged
merged 2 commits into from
Sep 30, 2021
Merged

Fix unit tests in pipeline #1529

merged 2 commits into from
Sep 30, 2021

Conversation

JohnMcPMS
Copy link
Member

@JohnMcPMS JohnMcPMS commented Sep 30, 2021 •
edited by ghost
Loading

Change

This fixes:

  • REST tests that were deadlocking due to not setting the response body in the test helpers.
  • The -logto unit test argument to now properly be the actual log path again.
  • The test script to fail on timeout rather than simply ending.
Microsoft Reviewers: Open in CodeFlow

@JohnMcPMS JohnMcPMS requested a review from a team as a code owner September 30, 2021 01:48
@JohnMcPMS
Copy link
Member Author

Confirmed that the unit tests are now showing in the results and the log file is no longer empty.

@JohnMcPMS JohnMcPMS merged commit 9454ff9 into microsoft:master Sep 30, 2021
@JohnMcPMS JohnMcPMS deleted the pipeline branch September 30, 2021 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yao-msft yao-msft yao-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JohnMcPMS @yao-msft