Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The source column is no longer shown in the table if a source was specified (list/upgrade). #1598

Merged
merged 3 commits into from
Oct 16, 2021

Conversation

jedieaston
Copy link
Contributor

@jedieaston jedieaston commented Oct 15, 2021


Resolves #1597.

Kind of jumping the gun as the issue wasn't triaged, but it was an easy fix (so no biggie if it isn't merged). It makes it consistent with the behavior of winget search -s <source>.

image

Microsoft Reviewers: Open in CodeFlow

@jedieaston jedieaston requested a review from a team as a code owner October 15, 2021 14:14
@ghost ghost added the Issue-Feature This is a feature request for the Windows Package Manager client. label Oct 15, 2021
@denelon
Copy link
Contributor

denelon commented Oct 15, 2021

I like it! It does mean that @RDMacLachlan and I have more work to do on the Invoke-Command.ps1 to handle different shaped table output, but it should also help with some of the truncation happening with long names and "Id"s.

@JohnMcPMS
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JohnMcPMS JohnMcPMS merged commit d46aea1 into microsoft:master Oct 16, 2021
@jedieaston jedieaston deleted the no-list-source-plz branch October 16, 2021 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The output of winget upgrade with --source option should exclude the source column
3 participants