Made all installer types lowercase during show.
#1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Issue-Bug
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This will change the value returned in com api, but maybe it's ok. |
|
I didn't think about that, although wouldn't the consumers of the COM API probably have the expectation that this value wasn't capitalized oddly? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The problem is just that if things change, then existing code can break. The good thing is that this change isn't likely to impact anyone. It would only affect getting the installer type of installed packages as far as I saw, and I don't know if anyone is even doing that right now. |
JohnMcPMS
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1685.
Microsoft Reviewers: Open in CodeFlow