Add basic proxy support #1776

eternalphane · 2021-12-05T15:47:25Z

Have you signed the Contributor License Agreement?
Are you working against an Issue?

Partially resolves #190.

--proxy option
--no-proxy option (may need a better name, e.g. proxy-bypass-list?)
network.proxy settings
network.proxyOverride settings (or proxyBypass?)
HTTP_PROXY, HTTPS_PROXY, FTP_PROXY, ALL_PROXY, NO_PROXY environment variables

TODOs (not in this pr):

authentication
PAC
protocol-specific proxy settings just like aria2 (not sure there's much use case)

Microsoft Reviewers: Open in CodeFlow

github-actions · 2021-12-05T15:48:34Z

@check-spelling-bot Report

Unrecognized words, please review:

stl

Previously acknowledged words that are now absent

activatable Archs Globals mytool

To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the git@github.com:eternalphane/winget-cli.git repository
on the proxy-support branch:

update_files() {
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
  --header "Content-Type: application/json" \
  "https://api.github.com/repos/microsoft/winget-cli/issues/comments/986253593" > "$comment_json"
comment_body=$(mktemp)
jq -r .body < "$comment_json" > $comment_body
rm $comment_json

patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")
  

patch_add=$(perl -e '$/=undef;
$_=<>;
s{<details>.*}{}s;
s{^#.*}{};
s{\n##.*}{};
s{(?:^|\n)\s*\*}{}g;
s{\s+}{ }g;
print' < "$comment_body")
  
update_files
rm $comment_body
git add -u

github-actions · 2021-12-05T17:07:16Z

@check-spelling-bot Report

Unrecognized words, please review:

stl

Previously acknowledged words that are now absent

activatable Archs Globals mytool

To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the git@github.com:eternalphane/winget-cli.git repository
on the proxy-support branch:

update_files() {
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
  --header "Content-Type: application/json" \
  "https://api.github.com/repos/microsoft/winget-cli/issues/comments/986266371" > "$comment_json"
comment_body=$(mktemp)
jq -r .body < "$comment_json" > $comment_body
rm $comment_json

patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")
  

patch_add=$(perl -e '$/=undef;
$_=<>;
s{<details>.*}{}s;
s{^#.*}{};
s{\n##.*}{};
s{(?:^|\n)\s*\*}{}g;
s{\s+}{ }g;
print' < "$comment_body")
  
update_files
rm $comment_body
git add -u

github-actions · 2021-12-11T03:55:32Z

@check-spelling-bot Report

Unrecognized words, please review:

stl

Previously acknowledged words that are now absent

activatable Archs Globals mytool

To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the git@github.com:eternalphane/winget-cli.git repository
on the proxy-support branch:

update_files() {
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
  --header "Content-Type: application/json" \
  "https://api.github.com/repos/microsoft/winget-cli/issues/comments/991442641" > "$comment_json"
comment_body=$(mktemp)
jq -r .body < "$comment_json" > $comment_body
rm $comment_json

patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")
  

patch_add=$(perl -e '$/=undef;
$_=<>;
s{<details>.*}{}s;
s{^#.*}{};
s{\n##.*}{};
s{(?:^|\n)\s*\*}{}g;
s{\s+}{ }g;
print' < "$comment_body")
  
update_files
rm $comment_body
git add -u

github-actions · 2021-12-11T16:34:09Z

@check-spelling-bot Report

Unrecognized words, please review:

stl

Previously acknowledged words that are now absent

activatable Archs Globals mytool

To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the git@github.com:eternalphane/winget-cli.git repository
on the proxy-support branch:

update_files() {
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
  --header "Content-Type: application/json" \
  "https://api.github.com/repos/microsoft/winget-cli/issues/comments/991704345" > "$comment_json"
comment_body=$(mktemp)
jq -r .body < "$comment_json" > $comment_body
rm $comment_json

patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")
  

patch_add=$(perl -e '$/=undef;
$_=<>;
s{<details>.*}{}s;
s{^#.*}{};
s{\n##.*}{};
s{(?:^|\n)\s*\*}{}g;
s{\s+}{ }g;
print' < "$comment_body")
  
update_files
rm $comment_body
git add -u

github-actions · 2021-12-11T17:12:36Z

@check-spelling-bot Report

Unrecognized words, please review:

stl

Previously acknowledged words that are now absent

activatable Archs Globals mytool

To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the git@github.com:eternalphane/winget-cli.git repository
on the proxy-support branch:

update_files() {
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
  --header "Content-Type: application/json" \
  "https://api.github.com/repos/microsoft/winget-cli/issues/comments/991716200" > "$comment_json"
comment_body=$(mktemp)
jq -r .body < "$comment_json" > $comment_body
rm $comment_json

patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")
  

patch_add=$(perl -e '$/=undef;
$_=<>;
s{<details>.*}{}s;
s{^#.*}{};
s{\n##.*}{};
s{(?:^|\n)\s*\*}{}g;
s{\s+}{ }g;
print' < "$comment_body")
  
update_files
rm $comment_body
git add -u

denelon · 2021-12-13T15:18:44Z

@eternalphane to resolve the spelling issue, you may add "stl" in alphabetical order to expect.txt.

We will look at this when we have a few more of the engineering team members back from holidays.

denelon · 2021-12-14T17:50:27Z

Thanks @eternalphane.

Just to let you know, this should be converted to a draft PR. We're going to need to have a security review on this feature. Anything to do with networking requires some internal reviews which will take some calendar time to coordinate with the other required teams.

Thanks so much for the contribution here! I'm sure plenty of users will be thrilled.

neoribs · 2022-08-04T14:53:24Z

Is it already working?

lemchen · 2022-08-07T05:36:23Z

Is it already working?

Not yet. It seems to be implemented in v1.5
https://github.com/microsoft/winget-cli/milestone/39

char-46 · 2023-10-03T17:34:29Z

Is there any newer plan to make it come true?

For #190 See spec on #4152 See #1776 for a related PR for the feature with the core implementation for proxies in wininet This PR adds basic support for using proxies. Most of the changes are for enabling the configuration and blocking of the feature. This feature will be gated behind an experimental feature setting * Added Group Policy and Admin settings for enabling/disabling the use of proxy CLI arguments and for setting a default proxy. + Pending: Internal review for new Group Policy + Extended `AdminSettings` to support settings with string values, instead of only bool flags. The implementation is mostly a copy of the bool case. In the future we should look back at it to reduce duplication of code. + Added a `set` subcommand to `settings` that can set the admin settings * Added CLI arguments to select a proxy on each different invocation of winget, or to disable the use of a default one. * Updated calls to wininet and cpprestsdk to use the provided proxy, and added plumbing to get the arguments from the command line to the point of use. * Changed the flow around downloads to force winget to use proxies if available. Manually tested on a VM using mitmproxy Pending: Adding automated tests tests. Co-authored-by: yao-msft <50888816+yao-msft@users.noreply.github.com>

add proxy settings

17d7999

ghost added the Issue-Feature This is a feature request for the Windows Package Manager client. label Dec 5, 2021

add proxyOverride settings

366df54

add options for proxy support

fb5430d

eternalphane changed the title ~~Add proxy support~~ Add basic proxy support Dec 11, 2021

eternalphane added 2 commits December 12, 2021 00:16

add docs

ba795ac

support comma-seperated NO_PROXY; fix NVRO

a6c2fa3

Merge branch 'master' into proxy-support

62c812e

eternalphane marked this pull request as ready for review December 11, 2021 17:12

eternalphane requested a review from a team as a code owner December 11, 2021 17:12

fix spelling

97838b4

eternalphane marked this pull request as draft December 16, 2021 13:42

char-46 mentioned this pull request Oct 3, 2023

Proxy options support #190

Open

eizedev mentioned this pull request Dec 27, 2023

[FEATURE REQUEST] It is necessary to add proxy settings marticliment/WingetUI#1016

Open

4 tasks

This was referenced Feb 22, 2024

Add spec for proxy support #4152

Merged

Add support for proxies #190 #4203

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add basic proxy support #1776

Add basic proxy support #1776

eternalphane commented Dec 5, 2021 •

edited

github-actions bot commented Dec 5, 2021 •

edited

github-actions bot commented Dec 5, 2021 •

edited

github-actions bot commented Dec 11, 2021 •

edited

github-actions bot commented Dec 11, 2021 •

edited

github-actions bot commented Dec 11, 2021 •

edited

denelon commented Dec 13, 2021

denelon commented Dec 14, 2021

neoribs commented Aug 4, 2022 •

edited

lemchen commented Aug 7, 2022 •

edited

char-46 commented Oct 3, 2023

Add basic proxy support #1776

Are you sure you want to change the base?

Add basic proxy support #1776

Conversation

eternalphane commented Dec 5, 2021 • edited

Microsoft Reviewers: Open in CodeFlow

github-actions bot commented Dec 5, 2021 • edited

@check-spelling-bot Report

Unrecognized words, please review:

github-actions bot commented Dec 5, 2021 • edited

@check-spelling-bot Report

Unrecognized words, please review:

github-actions bot commented Dec 11, 2021 • edited

@check-spelling-bot Report

Unrecognized words, please review:

github-actions bot commented Dec 11, 2021 • edited

@check-spelling-bot Report

Unrecognized words, please review:

github-actions bot commented Dec 11, 2021 • edited

@check-spelling-bot Report

Unrecognized words, please review:

denelon commented Dec 13, 2021

denelon commented Dec 14, 2021

neoribs commented Aug 4, 2022 • edited

lemchen commented Aug 7, 2022 • edited

char-46 commented Oct 3, 2023

eternalphane commented Dec 5, 2021 •

edited

github-actions bot commented Dec 5, 2021 •

edited

github-actions bot commented Dec 5, 2021 •

edited

github-actions bot commented Dec 11, 2021 •

edited

github-actions bot commented Dec 11, 2021 •

edited

github-actions bot commented Dec 11, 2021 •

edited

neoribs commented Aug 4, 2022 •

edited

lemchen commented Aug 7, 2022 •

edited