Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved "Installing Dependencies" message to only print if there are dependencies to install. #1851

Merged
merged 1 commit into from Jan 13, 2022

Conversation

jedieaston
Copy link
Contributor

@jedieaston jedieaston commented Jan 13, 2022


Small change to make sure that the "Installing Dependencies: " string only prints if there are actually dependencies installing. The way it was, if all of the dependencies were already installed it looked like the package the user requested was a dependency.

PS C:\Users\easton> wingetdev install handbrake
Found HandBrake [HandBrake.HandBrake] Version 1.5.1
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
This package requires the following dependencies:
  - Packages
      Microsoft.dotnetRuntime.5-x64
Downloading https://github.com/HandBrake/HandBrake/releases/download/1.5.1/HandBrake-1.5.1-x86_64-Win_GUI.exe
  ██████████████████████████████  19.4 MB / 19.4 MB
Successfully verified installer hash
Starting package install...
Successfully installed

(Note how the 6th line isn't "Installing Dependencies")

I suppose the other change should be that the "This package requires the following dependencies" list shouldn't be presented if you have all of the dependencies already installed (since if you want the full list you can get it via winget show anyway), but that'll probably require a couple changes to ReportDependencies().

Microsoft Reviewers: Open in CodeFlow

@jedieaston jedieaston requested a review from a team as a code owner January 13, 2022 15:27
@yao-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants