Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display fine-grained blocks in progress bars #2046

Merged
merged 2 commits into from Mar 30, 2022
Merged

Display fine-grained blocks in progress bars #2046

merged 2 commits into from Mar 30, 2022

Conversation

chausner
Copy link
Contributor

@chausner chausner commented Mar 26, 2022 •
edited by ghost

This enhances the progress bar to use more fine-grained blocks, in steps of 1/8 of the width of a block, by leveraging the Block Element Unicode characters.

E.g. before:

image

After:

image

Microsoft Reviewers: Open in CodeFlow

@chausner chausner requested a review from a team as a code owner March 26, 2022 00:32
@JohnMcPMS
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JohnMcPMS JohnMcPMS merged commit 93f8690 into microsoft:master Mar 30, 2022
@denelon
Copy link
Contributor

denelon commented Mar 30, 2022

Very cool!

@chausner chausner deleted the smooth-progressbar branch March 30, 2022 17:48
@JohnMcPMS
Copy link
Member

smooth

@denelon denelon linked an issue Mar 30, 2022 that may be closed by this pull request
An even better progress bar #2055
Closed
@JohnMcPMS JohnMcPMS mentioned this pull request Apr 14, 2022
Open
@sba923
Copy link

sba923 commented Apr 15, 2022

Given #2099 I would opt for a winget setting under visual to enable the smooth progress, with a default value of false.

@sba923
Copy link

sba923 commented Apr 16, 2022

There must be a way to force winget list (or another non-install-related command) to produce a (slow-growing) progress bar for testing, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnMcPMS JohnMcPMS JohnMcPMS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

An even better progress bar
4 participants
@chausner @JohnMcPMS @denelon @sba923