Use UpgradeCode for matching MSI apps
#2418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Manifest
florelis
commented
Aug 4, 2022
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
JohnMcPMS
approved these changes
Aug 11, 2022
src/AppInstallerRepositoryCore/Microsoft/Schema/1_1/Interface_1_1.cpp
Outdated
Show resolved
Hide resolved
florelis
commented
Aug 12, 2022
Comment on lines
+80
to
+81
| // There is no UpgradeCodes key on the x86 view of the registry | ||
| Registry::Key upgradeCodesKey = Registry::Key::OpenIfExists(HKEY_LOCAL_MACHINE, "SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Installer\\UpgradeCodes", 0, KEY_READ | KEY_WOW64_64KEY); |
There was a problem hiding this comment.
Small important change since the review to fix test failure.
There was a problem hiding this comment.
It does make sense that these would only be stored in the OS architecture.
JohnMcPMS
approved these changes
Aug 12, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for using an installer's
UpgradeCodefrom theAppsAndFeaturesEntriesfor matching against the installed apps.PackageVersionMultiPropertyandSystemReferenceStringAppsAndFeaturesEntriesCloses #1145
Microsoft Reviewers: Open in CodeFlow