Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat Microsoft.WinGet.Client module output #3088

Merged
merged 6 commits into from Mar 23, 2023

Conversation

ryfu-msft
Copy link
Contributor

@ryfu-msft ryfu-msft commented Mar 18, 2023

Changes:

Restructures the Microsoft.WinGet.Client module binaries output so that it is in the format of lib\$framework\$architecture\.... This is to ensure that we can create the nuget package successfully.

: 'lib' is the required folder name of the binaries in a nuget package and frameworks must be specified in the folder structure.

Microsoft Reviewers: Open in CodeFlow

@ryfu-msft ryfu-msft requested a review from a team as a code owner March 18, 2023 00:46
@ryfu-msft ryfu-msft marked this pull request as draft March 20, 2023 18:58
@ryfu-msft ryfu-msft marked this pull request as ready for review March 21, 2023 16:46
@ryfu-msft ryfu-msft changed the title Reformat Microsoft.WinGet.Client module output and publish nuget package Reformat Microsoft.WinGet.Client module output Mar 22, 2023
@ryfu-msft
Copy link
Contributor Author

Removed nuspec file as I think it would be better to move it to the AppInstaller pipeline where we sign the module files.

@ryfu-msft ryfu-msft requested a review from yao-msft March 22, 2023 21:27
@ryfu-msft ryfu-msft merged commit ea86a01 into microsoft:master Mar 23, 2023
8 checks passed
@ryfu-msft ryfu-msft deleted the reformatPowershell branch March 23, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants